Update for Unity3d 2018.3.8f1#1
Open
cschladetsch wants to merge 41 commits intodarcy-rayner:masterfrom
Open
Conversation
Owner
|
Hey Christian 👋 . Thanks for the PR. Do you think you'd be able to make a version that doesn't rename Command to Cmd. I don't want to add a major breaking change like that to the library, and it makes it hard to see what the relevant changes were. |
Author
|
Oh, I didn't mean to push that. I'll look into it later.
…On Sun, Mar 24, 2019 at 10:45 AM Darcy Rayner ***@***.***> wrote:
Hey Christian 👋 . Thanks for the PR. Do you think you'd be able to make
a version that doesn't rename Command to Cmd. I don't want to add a major
breaking change like that to the library, and it makes it hard to see what
the relevant changes were.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACH8ZgZq5L0tmajRET1l1yNu0Re1B6TXks5vZryIgaJpZM4b7512>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were various references to deprecated types, like GUITexture and GUIText.
I commented them out, rather than deleting them, in case you wanted to wrap them around #ifdefs.
No real functional changes, just making it work with 2018.3.8f1 without warnings.